Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPM1730] Suisin/fix: logout not redirected to app.deriv.com and it is showing pnv can… #17483

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[UPM1730] Suisin/fix: logout not redirected to app.deriv.com and it is showing pnv can… #17483

wants to merge 2 commits into from

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Nov 12, 2024 •
edited
Loading

…cel modal

Changes:

Fix logout showing cancel verification modal

Screenshots:

Screen.Recording.2024-11-12.at.4.45.53.PM.mov

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 15, 2024 6:53am

@suisin-deriv suisin-deriv force-pushed the suisin/UPM1730/unusual_behavior_in_pnv_logout branch from 484fb3d to c9d3694 Compare November 12, 2024 08:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17483](https://github.com/deriv-com/deriv-app/pull/17483)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1730unusualbeh-859c03.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1730unusualbeh-859c03.binary.sx
- **App ID**: `23835`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm1730unusualbeh-859c03.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Nov 14, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11851439240

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 53.173%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/AccountSwitcher/account-switcher.jsx 0 2 0.0%
Totals Coverage Status
Change from base Build 11850997705: -0.003%
Covered Lines: 32714
Relevant Lines: 57420
💛 - Coveralls

@suisin-deriv suisin-deriv force-pushed the suisin/UPM1730/unusual_behavior_in_pnv_logout branch from ea12d1a to 7a086ea Compare November 15, 2024 06:29
@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@amina-deriv amina-deriv amina-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suisin-deriv @coveralls @amina-deriv @likhith-deriv